Ticket #16 (assigned defect)

Opened 3 years ago

Last modified 2 years ago

[patch] Hack to add NETWM fullscreen support

Reported by: shadow@serverart.org Assigned to: giblet (accepted)
Priority: normal Milestone: feh 1.3.5
Component: X11 Version: 1.3.4
Severity: normal Keywords:
Cc:

Description

Using feh (svn HEAD r52) with Metacity window manager, fullscreen mode does not cover the entire screen properly. This is due to lack of NETWM fullscreen support.

Attachments

thepatch.diff (1.2 kB) - added by shadow@serverart.org on 03/05/06 00:10:38.
Hack to make NETWM fullscreen function. (Diff against svn HEAD r52)
thepatch.2.diff (1.2 kB) - added by shadow@serverart.org on 03/05/06 00:20:36.
Updated, Hack to make NETWM fullscreen function. (Diff against svn HEAD r52)

Change History

03/05/06 00:10:38 changed by shadow@serverart.org

  • attachment thepatch.diff added.

Hack to make NETWM fullscreen function. (Diff against svn HEAD r52)

03/05/06 00:15:14 changed by anonymous

eek, patch needs work.

03/05/06 00:20:36 changed by shadow@serverart.org

  • attachment thepatch.2.diff added.

Updated, Hack to make NETWM fullscreen function. (Diff against svn HEAD r52)

03/05/06 00:21:28 changed by shadow@serverart.org

Okay, patch updated. should compile now.

03/29/06 06:12:37 changed by cian.cullinan@gmail.com

Just tried this with FC4 and metacity but it didn't work: the gnome panels at the top and bottom of the screen remain overlayed on the image until I right-click on the image, then all is well - I.E.: proper full screen.

03/29/06 06:13:35 changed by cian.cullinan@gmail.com

Sorry, should have mentioned, this is with r52 and thepatch.2.diff.

04/14/06 10:36:49 changed by anonymous

The patch works for me, I applied it to the Debian source package of 1.3.4. It's true that it doesn't go straight to the top, but that's because of metacity's focus-stealing prevention. The gnome panel also blinks feh in the windowlist to indicate this. If I do feh foo.jpg then click on feh in the windowlist, pressing 'v' goes fullscreen perfectly.

Good work shadow!

08/06/06 00:44:15 changed by andrewc

  • milestone changed from feh 1.3.4 to feh 1.3.5.

Just confirming that thepatch.2.diff applies cleanly and shows the behaviour I'd expect under Ubuntu dapper (feh 1.3.4, GNOME, metacity 2.14.5). Fullscreen windows go directly to the top whether specified as the starting state in the current theme or toggled on using "v".

Remilestoneing to 1.3.5 because 1.3.4 has been released. Hope that's OK.

08/06/06 18:41:08 changed by giblet

  • status changed from new to assigned.

oh good stuff. applied in [54]